Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade to Yarn 4.1.1 and Node 20 in CI #3934

Merged
merged 2 commits into from Mar 12, 2024
Merged

chore: upgrade to Yarn 4.1.1 and Node 20 in CI #3934

merged 2 commits into from Mar 12, 2024

Conversation

edemaine
Copy link
Member

@edemaine edemaine commented Mar 7, 2024

What is the previous behavior before this PR?
Yarn 3.2.2, which didn't support modern Node (see #3931).
CI used Node 14 and 16.

What is the new behavior after this PR?
Latest version of Yarn 4.1.1, which no longer requires checking in the Yarn binary to the repository.
Instead we require developers to run the command corepack enable (once per machine) before yarn.
Also requires developers to use Node 18+ (as required by Yarn 4).
CI now uses Node 20 and calls corepack enable.

Fixes #3931

Requires developers to use Node 18+ and `corepack enable`
Copy link

codecov bot commented Mar 7, 2024

Codecov Report

Merging #3934 (02ea6e3) into main (3d5de92) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3934   +/-   ##
=======================================
  Coverage   92.99%   92.99%           
=======================================
  Files          91       91           
  Lines        6779     6779           
  Branches     1576     1576           
=======================================
  Hits         6304     6304           
  Misses        437      437           
  Partials       38       38           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d5de92...02ea6e3. Read the comment docs.

@edemaine edemaine merged commit 8910f16 into main Mar 12, 2024
9 checks passed
@edemaine edemaine deleted the yarn-upgrade branch March 12, 2024 20:13
@KaTeX-bot
Copy link
Member

🎉 This PR is included in version 0.16.10 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants