Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vertically center single-character \mathop. #745

Merged
merged 2 commits into from Jun 30, 2017

Conversation

kohler
Copy link
Collaborator

@kohler kohler commented Jun 29, 2017

Fixes issue #726.

@kevinbarabash
Copy link
Member

@kohler how did you test this? Could you post some (before/after) screenshots \mathop expressions that are affected by this change?

@kohler
Copy link
Collaborator Author

kohler commented Jun 29, 2017

Sure, I tested many expressions. Here's an expression that encompasses a lot of em

a\mathop+b\mathop:c\mathop{\delta}e\mathop{\textrm{and}}f\mathrel{\mathop{:}}=g\sin h

Before

image

After

image

Note that the :s moved up (as they should), the \delta moved down (as it should: https://tex.stackexchange.com/questions/368673/documentation-of-mathop), and the other ones stayed put (as they should).

@kohler
Copy link
Collaborator Author

kohler commented Jun 29, 2017

NB Other uses of groupTypes.op that could have been affected, such as \stackrel, are tested in the screenshotter tests.

@kevinbarabash
Copy link
Member

Looks good. Can you add a screenshot test for that? Screenshots for single tests can be generated using the include option, e.g. dockers/Screenshotter/screenshotter.sh --include=Sqrt.

@kohler
Copy link
Collaborator Author

kohler commented Jun 30, 2017

test added

@edemaine
Copy link
Member

Looks great! Thanks for fixing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants