Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kerosene-ui: Fix useRect eventList #52

Merged
merged 2 commits into from
Sep 24, 2019
Merged

kerosene-ui: Fix useRect eventList #52

merged 2 commits into from
Sep 24, 2019

Conversation

nhardy
Copy link
Member

@nhardy nhardy commented Sep 23, 2019

  • Ensures that listeners are added/removed when the eventList changes
  • Allows eventList parameter to accept a readonly array.

@nhardy nhardy added the bug Something isn't working label Sep 23, 2019
@nhardy nhardy requested a review from glie163 September 23, 2019 02:45
@github-actions
Copy link

Coverage Status

Coverage increased (+0.02%) to 91.468% when pulling 175fa33 on bugfix/kerosene-ui-useRect into c5f4672 on master.

@nhardy nhardy merged commit f916f47 into master Sep 24, 2019
@nhardy nhardy deleted the bugfix/kerosene-ui-useRect branch September 24, 2019 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ojkelly ojkelly ojkelly approved these changes

@glie163 glie163 Awaiting requested review from glie163

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nhardy @ojkelly