This repository has been archived by the owner on Jan 14, 2020. It is now read-only.
Small fixes #114
Merged
Small fixes #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbaggerman
suggested changes
Sep 17, 2018
| "", | ||
| ) | ||
| printer.SubStep("Cleaning up unused change set", 1, true, true) | ||
| _, err := cf.DeleteChangeSet( |
There was a problem hiding this comment.
This is causing a test failure, since the cfn wrapper is called client rather than cf.
| ) | ||
| } | ||
| printer.Stop() | ||
| os.Exit(1) |
There was a problem hiding this comment.
Can we please not call os.Exit(1) directly? It complicates testing. Use printer.Fatal, or refactor the function to return an error, and let it cascade back out of the testable path.
There was a problem hiding this comment.
Yeah good pickup, this was a quick fix, not ideal to merge in like that.
There was a problem hiding this comment.
After double checking, I've noticed that there's more os.Exit calls scattered around the place. I think I'll make a pass at trying to refactor those out.
dbaggerman
approved these changes
Sep 27, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has some fixes to minor regressions.