Skip to content
This repository has been archived by the owner on Jan 14, 2020. It is now read-only.

Add more unit tests to plugin manager #44

Merged
merged 9 commits into from Jun 13, 2018
Merged

Add more unit tests to plugin manager #44

merged 9 commits into from Jun 13, 2018

Conversation

ojkelly
Copy link
Contributor

@ojkelly ojkelly commented Jun 12, 2018

Fixes #24

@coveralls
Copy link

coveralls commented Jun 12, 2018 •
edited

Pull Request Test Coverage Report for Build 206

  • 19 of 46 (41.3%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+6.3%) to 25.197%
Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/manifest/init.go 0 2 0.0%
internal/plugins/install.go 0 5 0.0%
internal/manifest/manifest.go 0 10 0.0%
internal/plugins/add.go 19 29 65.52%
Totals Coverage Status
Change from base Build 192: 6.3%
Covered Lines: 288
Relevant Lines: 1143
💛 - Coveralls

@ojkelly ojkelly changed the title WIP: Add more unit tests to plugin manager Add more unit tests to plugin manager Jun 13, 2018
@ojkelly ojkelly merged commit 95b943e into master Jun 13, 2018
@ojkelly
Copy link
Contributor Author

ojkelly commented Jun 13, 2018

More tests around plugin manager to come, with #23

@ojkelly ojkelly deleted the ok/issue-24 branch June 14, 2018 06:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ojkelly @coveralls