[Please test] Add AppImage build script #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jbruechert
commented
Nov 20, 2017
•
jbruechert
commented
lnjX
reviewed
Nov 20, 2017
utils/AppImage.sh
Outdated
| fi | ||
|
|
||
| # configure buildsystem and environment for AppDir installation | ||
| mkdir ../build |
There was a problem hiding this comment.
Yeah I could do that but it would work anyway, just throw a warning. As this code will land on a throw-away container on the CI most likely, it would not be that important.
There was a problem hiding this comment.
Not that important, but it's cleaner.
|
FYI: I tested it and I got this error: Looks like it's missing in the mounted image... |
lnjX
approved these changes
Nov 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.