Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getResourcePath: Add binary relative paths #143

Merged
merged 1 commit into from
Nov 25, 2017

Conversation

lnjX
Copy link
Member

@lnjX lnjX commented Nov 25, 2017

Fixes #141.

@lnjX
Copy link
Member Author

lnjX commented Nov 25, 2017

But please test it first in the AppImage. The path is correct, but I haven't tested it in a new appimage.

@jbruechert
Copy link
Member

The appimage does now work and load the Kaidan ressources, however the icons in the drawer didn't appear on the debian installation I tested the new AppImage on. This doesn't make the appimage useless, but we should fix that too.

@jbruechert
Copy link
Member

Btw, can we only use this way of finding the ressources on UNIX and the QStandardPaths way on windows?

@lnjX
Copy link
Member Author

lnjX commented Nov 25, 2017

Currently both are combined, it will search everywhere...

@jbruechert
Copy link
Member

Sorry, I didn't see that. So we can merge this

@jbruechert jbruechert merged commit da38011 into KaidanIM:master Nov 25, 2017
@lnjX lnjX deleted the fix/relative-resource-paths branch November 25, 2017 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants