Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes the image retrieval part work without too much effort. (should address issues #64 and #109) #156

Merged
merged 18 commits into from
Mar 17, 2022

Conversation

rafiberlin
Copy link
Contributor

I have made some modifications to the code to be able to run the image retrieval part with the pre-trained SGDet Model you uploaded. With proper pre-configuration, the only hard coded path are in tools/image_retrieval_main.py.

The main changes:

The evaluator uses normalized cosine similarity for the scoring.
There s some handling for bad training samples (samples with no relationships)
Some input Tensors needed to be transposed to enable the network to train properly.

@rafiberlin rafiberlin changed the title Makes the image retrieval part work without too much effort. Makes the image retrieval part work without too much effort. (should address issues #64 and #109) Dec 21, 2021
@rafiberlin
Copy link
Contributor Author

I added a script that shows how the sentence scene graphs were created (can''t recreate exactly the same text graph, as this is based on Spacy Parsing and it has changed since the original version). I also added an evaluation script for image retrieval with another logic.

PS: I believe, that could have achieve better performance, if you had trained for only 9 / 10 epochs. I am using your code for a project and some results can be found here:

https://github.com/rafiberlin/WS21_IM_map_world_image_retrieval/blob/main/avatar_sgg/notebooks/plot_metrics.ipynb

@KaihuaTang KaihuaTang merged commit 634a6e2 into KaihuaTang:master Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants