separate qt display and video #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In the meantime I pushed separating the experience replay loop as well, so that got into this PR as well. |
|
Yeah saw that - ideally should be 2 PRs but never mind. I'm just having a quick look over the code - will only test after you're finished with #23. Then once #5 is finished I'll do a more thorough code review. Btw with respect to #5 I'd suggest using the "correct" but non-converging SARSA agent, and then raising a separate issue to keep track of the problem. |
|
@Kaixhin yes wanted 2 separate PRs, so pushed the new commit after opening this PR, just didn't realize github adds new push to an outstanding PR automatically. Agreed, will change Sarsa to be the "correct" algorithm and later will continue later in separate issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.