Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of the Cross Domain Adaptive Clustering(Domain Adaptation) #44

Merged
merged 4 commits into from Jun 24, 2022
Merged

Conversation

shreejalt
Copy link

Hi,
Thanks for your excellent repository for different DA/SSL/DG algorithms. I found the CDAC paper very interesting, and I have implemented the paper in your repo and would like to merge it with your main Dassl repository.

Link to the paper: Link
The original implementation by the authors can be found from this link: Link

Citing the original paper.

@InProceedings{li2021cross,
    author    = {Li, Jichang and Li, Guanbin and Shi, Yemin and Yu, Yizhou},
    title     = {Cross-Domain Adaptive Clustering for Semi-Supervised Domain Adaptation},
    booktitle = {Proceedings of the IEEE/CVF Conference on Computer Vision and Pattern Recognition (CVPR)},
    month     = {June},
    year      = {2021},
    pages     = {2505-2514}
}

@KaiyangZhou
Copy link
Owner

Thanks very much! Your implementation looks clean.

Is it a CVPR'19 or CVPR'21 paper? The update in the readme file puts CVPR'19 by the way.

Also, is this re-implementation tested? Do you have any numbers on the two datasets?

@shreejalt
Copy link
Author

Hi,
Sorry from my side, I will edit it to CVPR'21. Yes, I have tested the implementation. I have the numbers on the digit5 dataset

@shreejalt
Copy link
Author

Hi @KaiyangZhou ,
Any updates regarding the PR?

@KaiyangZhou
Copy link
Owner

Sorry, was very busy.

The code looks nice and ready to be merged.

One last check: could you please run linter.sh and fix any warnings related to this PR. Thanks!

@shreejalt
Copy link
Author

Hi @KaiyangZhou
I have done the linter.sh and committed the code again. I have also added the custom lr scheduler that the paper uses in their experiments.

Thanks alot

@KaiyangZhou KaiyangZhou merged commit 41811e4 into KaiyangZhou:master Jun 24, 2022
@shreejalt
Copy link
Author

shreejalt commented Jun 25, 2022

Hi @KaiyangZhou
There is a small bug in the scheduler function that I just checked

Can I correct it and the you can again merge?

i will creat a new PR with the solved bug and then you can merge it

thanks and sorry for inconvenience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants