Combine semantic matchers from all ancestor nodes #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matzuk
reviewed
Apr 26, 2022
compose/src/main/kotlin/io/github/kakaocup/compose/node/core/BaseNode.kt
Show resolved
Hide resolved
Vacxe
reviewed
Apr 27, 2022
| */ | ||
| private fun combineSemanticMatchers(): SemanticsMatcher { | ||
| val semanticsMatcherList = mutableListOf<SemanticsMatcher>() | ||
| var currentParent = this.parentNode |
There was a problem hiding this comment.
Is it possible to have non-current parent? Just past or next parent. In general can be just a parent
| semanticsMatcherList.add(this.nodeMatcher.matcher) | ||
|
|
||
| return semanticsMatcherList.reduce { finalMatcher, matcher -> finalMatcher and matcher } | ||
| } | ||
| } |
| val navigationButton: KNode = child { | ||
| hasTestTag("NavigateSecondScreenButton") | ||
| } | ||
| } |
| val sharedWidget: SharedWidgetNode = child { | ||
| hasTestTag("SharedWidget") | ||
| } | ||
| } |
| val title: KNode = child { | ||
| hasTestTag("SharedWidgetTitle") | ||
| } | ||
| } |
| } | ||
| } | ||
| } | ||
| } |
| private enum class NavigationScreen { | ||
| First, | ||
| Second | ||
| } |
Vacxe
approved these changes
Apr 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.