Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement - Add support for content checking and tint color for compose icon #70

Merged
merged 1 commit into from
Jan 2, 2024

Conversation

EvgenyMeltsaykin
Copy link

@EvgenyMeltsaykin EvgenyMeltsaykin commented Dec 6, 2023

No description provided.

@EvgenyMeltsaykin EvgenyMeltsaykin changed the title Enhancement - Add support for content checking and tint color for com… Enhancement - Add support for content checking and tint color for compose icon Dec 6, 2023
Copy link

@Unlimity Unlimity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're missing empty lines at the end of new files, please add them.

@EvgenyMeltsaykin
Copy link
Author

@Unlimity

I ran the command

git ls-files -z | while IFS= read -rd '' f; do tail -c1 < "$f" | read -r _ || echo >> "$f"; done

But too many files have changed. Should I start it now??

@Unlimity
Copy link

Unlimity commented Dec 7, 2023

No need to do this for the whole repo, just for the new files you add in your PR

@EvgenyMeltsaykin
Copy link
Author

@Unlimity

Done, please check that everything is fine

Copy link

@Unlimity Unlimity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Vacxe Vacxe changed the base branch from master to develop January 2, 2024 01:55
@Vacxe Vacxe self-requested a review January 2, 2024 01:55
@Vacxe Vacxe merged commit 2cca949 into KakaoCup:develop Jan 2, 2024
3 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants