Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ScrollViewActions support horizontal and nested scroll views #103

Merged
merged 3 commits into from
Nov 21, 2023

Conversation

Nikitae57
Copy link
Contributor

Blind fix, I didn't test it. Trying to fix exception below when trying to scroll to end NestedScrollView. While I'm at it, added HorizontalScrollVIew

<androidx.core.widget.NestedScrollView
    android:id="@+id/nested_scroll">
    ...
</androidx.core.widget.NestedScrollView
val scroll = KScrollView { withId(R.id.nested_scroll) }

scroll {
    scrollToEnd()
}
androidx.test.espresso.PerformException: Error performing 'Scroll ScrollView to end' on view '(view.getId() is <...id/nested_scroll>)'.
Caused by: java.lang.RuntimeException: Action will not be performed because the target view does not match one or more of the following constraints:
(is assignable from class <class android.widget.ScrollView> and (view has effective visibility <VISIBLE> and view.getGlobalVisibleRect() to return non-empty rectangle))

@Vacxe
Copy link
Member

Vacxe commented Nov 16, 2023

Thanks for the contribution. Could you please add UI tests for each case?

@Vacxe Vacxe changed the base branch from master to develop November 21, 2023 12:13
Copy link
Member

@Vacxe Vacxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for the contribution, merged to develop for UI testing

@Vacxe Vacxe merged commit 9928db6 into KakaoCup:develop Nov 21, 2023
3 of 11 checks passed
@Vacxe Vacxe mentioned this pull request Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants