Add support text view style assertions bold and italic #59
Conversation
| private val isItalic: Boolean? = null | ||
| ) : BoundedMatcher<View, TextView>(TextView::class.java) { | ||
| override fun describeTo(description: Description) { | ||
| description.appendText("Text style doesn't match") |
There was a problem hiding this comment.
Just add a bit more for this reporting
There was a problem hiding this comment.
Yeah, will append similar information
|
|
||
| override fun matchesSafely(item: TextView): Boolean { | ||
| var compareResult = true | ||
| if (isBold != null) { |
There was a problem hiding this comment.
val boldCheck = isBolt?.let { item.typeface.isBold == it} ?: true
hongwei-bai
force-pushed
the
add-text-styles-n-compound-drawables-verifications
branch
5 times, most recently
from
c49467f
to
ebe5316
Compare
|
@hongwei-bai I terribly sorry, but I think will be better to have two separates With this approach we will have single responsibility + avoiding Boolean in constructor |
sure np @Vacxe. tbh I was swinging betweens the two. will make the changes. Thanks! 👍 |
hongwei-bai
force-pushed
the
add-text-styles-n-compound-drawables-verifications
branch
from
ebe5316
to
46ad1c4
Compare
hongwei-bai
force-pushed
the
add-text-styles-n-compound-drawables-verifications
branch
from
46ad1c4
to
8d9de25
Compare
Hi @Vacxe , feel typeface match might be quite strict sometimes(has to match style and weight too), maybe add this one as well for a few simple scenarios?