Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor bugfixes Dec 2023 #53

Merged
merged 1 commit into from
Dec 22, 2023
Merged

Minor bugfixes Dec 2023 #53

merged 1 commit into from
Dec 22, 2023

Conversation

KaliedaRik
Copy link
Owner

Fixes 2 small bugs:

  • Some mixin files were adding the default attributes they defined to both the prototype's defs object and the prototype object itself. Default attributes only need to be added to the defs object.
  • A small error in a few of the shared-vars constants used by the Rectangle factory, setting unnecessary attributes on rectangle instances.

@KaliedaRik KaliedaRik merged commit 7b17893 into v8-dev Dec 22, 2023
@KaliedaRik KaliedaRik deleted the minor-bugfixes-dec-2023 branch December 22, 2023 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant