Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From initial investigations, it's clear that canvas elements can be included in Popover elements. Which means that we need to do work to make sure SC plays nicely with such canvases.
This PR:
dom-021
- to investigate Popup functionalitytitle
androle
attributes set on the HTML <canvas> element, and also allow users to define accessibility label and description text on the canvas by setting newdata-label
anddata-description
attributes on the <canvas> element.mixin/anchor.js
andfactory/anchor.js
filesButton
object that can be used by artefacts and entitys. This operates in a similar fashion to theAnchor
object, creating and manipulating elements in the DOM which can be invoked by code and tracked when users navigate the page using the keyboard tab pageButton
object. This include a fix which was generating errors where certain entity types were not checking for updates toAnchor
objects, leading to a confusing navigation experience eg in democanvas-027
(the interactive video demo)scrawlNavigationHold
- a <div> element SC was (until now) adding to the top of every web page on which it ran. Totally unnecessary and redundant!canvas-027
to make the action labels (play/pause, listen/mute) tab-navigable