Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate Popover API #67

Merged
merged 8 commits into from
Jan 9, 2024
Merged

Investigate Popover API #67

merged 8 commits into from
Jan 9, 2024

Conversation

KaliedaRik
Copy link
Owner

@KaliedaRik KaliedaRik commented Jan 7, 2024

From initial investigations, it's clear that canvas elements can be included in Popover elements. Which means that we need to do work to make sure SC plays nicely with such canvases.

This PR:

  • adds a new demo - dom-021 - to investigate Popup functionality
  • Fix canvas constructor so that it will pick up title and role attributes set on the HTML <canvas> element, and also allow users to define accessibility label and description text on the canvas by setting new data-label and data-description attributes on the <canvas> element.
  • fixes some subtle bugs discovered in the mixin/anchor.js and factory/anchor.js files
  • adds a new Button object that can be used by artefacts and entitys. This operates in a similar fashion to the Anchor object, creating and manipulating elements in the DOM which can be invoked by code and tracked when users navigate the page using the keyboard tab page
  • Updates across the codebase to use the new Button object. This include a fix which was generating errors where certain entity types were not checking for updates to Anchor objects, leading to a confusing navigation experience eg in demo canvas-027 (the interactive video demo)
  • Remove the functionality around scrawlNavigationHold - a <div> element SC was (until now) adding to the top of every web page on which it ran. Totally unnecessary and redundant!
  • Update demo canvas-027 to make the action labels (play/pause, listen/mute) tab-navigable

@KaliedaRik KaliedaRik marked this pull request as draft January 7, 2024 14:35
@KaliedaRik KaliedaRik marked this pull request as ready for review January 8, 2024 19:17
@KaliedaRik KaliedaRik merged commit 6a8795b into v8-dev Jan 9, 2024
@KaliedaRik KaliedaRik deleted the investigate-popover-api branch January 9, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant