New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Syscalls module #536
Add Syscalls module #536
Conversation
Remove ingroup tags Co-authored-by: Falco Girgis <gyrovorbis@gmail.com>
More documentation fixes Co-authored-by: Falco Girgis <gyrovorbis@gmail.com>
rename syscall_gdrom_run_commands to syscall_gdrom_exec_server
Update naming of run_command elements
Add more detail to documentation
I believe this PR is Ready to GO! To summarize:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am approving this to let people know that I have reviewed it, tested that it builds, looked at Doxygen, and no longer feel I have anything to contribute or need from it; HOWEVER, it's too big for me to feel comfortable merging without @ljsebald.
Also, @QuzarDC and @DC-SWAT, did you have anything else to add?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic work! Totally inline with my #151 project of standardization. And with them all laid out like this we now have easy access to some undocumented/unused ones to explore.
Had one change request of a typo that was my fault to begin with (and left some extra comments for future work but that don't require any change). Then it's good to go.
Fix typo Co-authored-by: Donald Haase <quzar86@yahoo.com>
Here we are again but with a more slimmed down PR.
Tested on GDEMU using raster_melt, and custom example for biosfont. Havent tested flashrom but if the other syscalls work then I expect the flashrom ones to work too since they use the same code to make the system call.
Ive decided to look into DCLOAD syscalls at a later date.