Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return the passed model from withPagination (for convinience) #23

Merged
merged 1 commit into from
Jul 22, 2019
Merged

Return the passed model from withPagination (for convinience) #23

merged 1 commit into from
Jul 22, 2019

Conversation

borodean
Copy link
Contributor

Seems like a logical thing to me. This way instead of this...

constructor(Models) {
  this.Counter = Models.Counter;
  withPagination()(this.Counter);
}

...a developer can write this:

constructor(Models) {
  this.Counter = withPagination()(Models.Counter);
}

What do you think?

@Kaltsoon
Copy link
Owner

Yes, this makes sense

@Kaltsoon Kaltsoon closed this Jul 22, 2019
@Kaltsoon Kaltsoon reopened this Jul 22, 2019
@Kaltsoon Kaltsoon merged commit cb5b4ef into Kaltsoon:master Jul 22, 2019
@borodean borodean deleted the return-model branch July 22, 2019 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants