Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove SITEBLOCK_BLOCK from tiles with SPECIAL_STAIRS_DOWN #2

Merged
merged 1 commit into from
Jan 30, 2016

Conversation

jaksd
Copy link
Contributor

@jaksd jaksd commented Jan 29, 2016

For issue #1

@Kamal-Sadek
Copy link
Owner

Thanks for the commit! We might want to go back and add other objects (STAIRS_UP) to the check. I'll also go back later and check the csv file, because the issue likely came from there.

Kamal-Sadek added a commit that referenced this pull request Jan 30, 2016
Resolves #1, up stairs no longer stuck in walls
@Kamal-Sadek Kamal-Sadek merged commit a007f0c into Kamal-Sadek:master Jan 30, 2016
@jaksd
Copy link
Contributor Author

jaksd commented Jan 30, 2016

Thanks to you too!

might want to go back and add other objects (STAIRS_UP) to the check

That's a good idea, I'll have a look at that. I'll see if I can come up with something more elegant too, at the moment I'm thinking we should remove any doors adjacent to a stairwell with this issue as well since a door that you can walk around due to empty space around it doesn't make much sense. And ideally we should be checking that there is actually empty traversible space next to the stairs (so we aren't trapped inside a 3x3 block of wall)

check the csv file, because the issue likely came from there

I tried to figure this out but I couldn't find a csv file for the prison, could it be using the old map generation code?

@Kamal-Sadek
Copy link
Owner

Indeed, it doesn't have a csv because it's being loaded from sitemaps.txt in the art/ directory, under GOVERNMENT_PRISON. This might be a slightly bigger rabbit-hole than what I was expecting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants