Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat]: Support Polars DataFrame and make Pandas and Polars optional #57

Merged
merged 1 commit into from Mar 3, 2023
Merged

[Feat]: Support Polars DataFrame and make Pandas and Polars optional #57

merged 1 commit into from Mar 3, 2023

Conversation

0warning0error
Copy link
Contributor

No description provided.

@Asm-Def Asm-Def linked an issue Mar 2, 2023 that may be closed by this pull request
[Feat] Support for Polars #41
Closed
@Asm-Def Asm-Def self-requested a review March 2, 2023 16:06
@Asm-Def Asm-Def changed the base branch from main to feat-polars March 2, 2023 17:19
@Asm-Def
Copy link
Collaborator

Asm-Def commented Mar 2, 2023

Thanks for your nice work!
It'll be merged soon after some tests and minor adjustments

@Asm-Def Asm-Def mentioned this pull request Mar 2, 2023
Closed
@0warning0error
Copy link
Contributor Author

0warning0error commented Mar 3, 2023 •
edited

One thing I forget is that I deleted the graphic-walker.iife.js in the templates folder. Should I need to restore it?
我删了templates文件夹里的graphic-walker.iife.js，当时我觉得这是gwalker编译后的产物，需要我恢复它吗？

@Asm-Def
Copy link
Collaborator

Asm-Def commented Mar 3, 2023

I apologize for my late reply. There's no need to restore the js file here, I'll remove this file from the git history soon.

@Asm-Def Asm-Def changed the base branch from feat-polars to main March 3, 2023 16:32
@Asm-Def Asm-Def merged commit 2923d37 into Kanaries:main Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Asm-Def Asm-Def Asm-Def approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feat] Support for Polars
2 participants
@0warning0error @Asm-Def