Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add device storage information #662

Merged
merged 4 commits into from
May 10, 2024

Conversation

kimdv
Copy link
Contributor

@kimdv kimdv commented May 10, 2024

This can be used to add sensors for storage information.
And also add automation for storage warnings etc

tests/test_devices.py Outdated Show resolved Hide resolved
tests/test_devices.py Outdated Show resolved Hide resolved
@kimdv kimdv requested a review from Kane610 May 10, 2024 21:12
Copy link
Owner

@Kane610 Kane610 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome

@Kane610
Copy link
Owner

Kane610 commented May 10, 2024

Anything else you're planning to do before I do a new release?

@kimdv
Copy link
Contributor Author

kimdv commented May 10, 2024

Yes, maybe I will add

"temperatures": [
                {
                    "name": "CPU",
                    "type": "cpu",
                    "value": 66.0
                },
                {
                    "name": "Local",
                    "type": "board",
                    "value": 48.75
                },
                {
                    "name": "PHY",
                    "type": "board",
                    "value": 50.25
                }
            ],

That is taken from my Dream Machine SE

@Kane610
Copy link
Owner

Kane610 commented May 10, 2024

Yes, maybe I will add

"temperatures": [
                {
                    "name": "CPU",
                    "type": "cpu",
                    "value": 66.0
                },
                {
                    "name": "Local",
                    "type": "board",
                    "value": 48.75
                },
                {
                    "name": "PHY",
                    "type": "board",
                    "value": 50.25
                }
            ],

That is taken from my Dream Machine SE

Alright. I'll wait for your next PR before publishing next release

@Kane610 Kane610 merged commit bb5f1e2 into Kane610:master May 10, 2024
1 check passed
@kimdv kimdv deleted the kimdv/add-device-storage-information branch May 10, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants