Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore errors for EV_DELETE in EventListener #36

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

corteggo
Copy link

@corteggo corteggo commented May 1, 2023

During tests execution, we've experienced the following error multiple times:

Peasy/EventListener.swift:51: Fatal error: No such file or directory

Environment:

  • Xcode 14.2
  • macOS Monterrey 12.6 / macOS Ventura 13.2

After debugging, we noticed this is eventually received upon server.stop() invocation. The server was being started without any specific port, so Peasy looked for an available one. The fatalError invocation causes the test execution to fail even when tests pass.

In my opinion, this can be ignored for EV_DELETE. server.stop() is usually invoked within tearDown() so whatever happens to server while stopping is irrelevant for test execution results.

It caused a fatalError in EventListener for no particular reason because the server was being stopped
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant