feat: env & DB settings #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kangdyu
reviewed
Jun 28, 2022
| @@ -3,6 +3,6 @@ import { Injectable } from "@nestjs/common"; | |||
| @Injectable() | |||
| export class AppService { | |||
| getHello(): string { | |||
| return "Hello World!"; | |||
| return "Hello World1!"; | |||
Comment on lines
+3
to
+16
| @Entity() | ||
| export class User { | ||
| @PrimaryGeneratedColumn() | ||
| id: number; | ||
|
|
||
| @Column({ type: "varchar", length: "255", unique: true, nullable: false }) | ||
| username: string; | ||
|
|
||
| @Column({ type: "varchar", length: "255", nullable: false }) | ||
| password: string; | ||
|
|
||
| @Column({ type: "varchar", length: "255" }) | ||
| imageUrl: string; | ||
| } |
There was a problem hiding this comment.
email 추가했습니다!
| @@ -0,0 +1,18 @@ | |||
| import { Test, TestingModule } from '@nestjs/testing'; | |||
There was a problem hiding this comment.
prettier 설정 중에 singleQuote: false 옵션이 적용이 안된거같은데 혹시 에디터 상에서 formatOnSave 옵션 사용 안하고 있으면 커밋하기 전에 lint한번 돌려주세여
| @@ -0,0 +1,18 @@ | |||
| import { Test, TestingModule } from '@nestjs/testing'; | |||
| @@ -0,0 +1,4 @@ | |||
| import { Injectable } from '@nestjs/common'; | |||
Kangdyu
approved these changes
Jun 28, 2022
|
다음 PR에 반영 예정 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.