Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the oxford comma #195

Closed
jricher opened this issue Sep 5, 2015 · 2 comments
Closed

Use the oxford comma #195

jricher opened this issue Sep 5, 2015 · 2 comments
Labels
core Related to (original UMA1) core spec scope; may use obsolete language editorial Related to non-normative text errors rsrc-reg Related to resource registration (or the original UMA1 resource reg spec) V1.0.1

Comments

@jricher
Copy link

jricher commented Sep 5, 2015

The following sentence should probably use the oxford comma for clarity:

If the client's request at the protected resource has no RPT, or an invalid RPT or insufficient authorization data associate...

Replace with:

If the client's request at the protected resource has no RPT, an invalid RPT, or insufficient authorization data associate...

Other parts of the specification should use it, also, but this is the one example that jumped out.

@jricher
Copy link
Author

jricher commented Sep 5, 2015

This same text occurs in §3, §3.2, §3.3.1, and §3.3.2.

@xmlgrrl xmlgrrl added core Related to (original UMA1) core spec scope; may use obsolete language rsrc-reg Related to resource registration (or the original UMA1 resource reg spec) V1.0.1 editorial Related to non-normative text errors and removed V1.0.1 labels Sep 5, 2015
@xmlgrrl
Copy link

xmlgrrl commented Sep 7, 2015

I do love the Oxford comma!

But actually, in these cases, the text is technically correct as written. This is because the phrase "as determined through RPT status checking" applies only to the "invalid RPT" and "insufficient authorization data associated with an RPT" options.

I think I can improve the feel of all of these sentences and take away the urge to comma-ize by adding "...or has an invalid RPT, or insufficient...".

xmlgrrl added a commit that referenced this issue Sep 8, 2015
Made less Oxford-tantalizing.
@xmlgrrl xmlgrrl closed this as completed Sep 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Related to (original UMA1) core spec scope; may use obsolete language editorial Related to non-normative text errors rsrc-reg Related to resource registration (or the original UMA1 resource reg spec) V1.0.1
Projects
None yet
Development

No branches or pull requests

2 participants