Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ActionBarSherlock in conflict With Appcompatv7 #9

Closed
hugocroch opened this issue Jun 6, 2014 · 3 comments
Closed

ActionBarSherlock in conflict With Appcompatv7 #9

hugocroch opened this issue Jun 6, 2014 · 3 comments

Comments

@hugocroch
Copy link

Hi, I tried your library and this is nicely done! Unfortunately, in your library, you import in your depedencies the appcompat-v7 and when I import it in my project, it is in conflict with the ActionBarSherlock.

So, I decided to download the source and remove the appcompat or at least see why the appcompat is in the project.

From my opinion, the appcompat is useless in the library. The only reason why it's there, it's because the theme(defined in the style.xml) in the Manifest come from the appcompat.

I would suggest to simply remove the the appcompat to avoid conflict in project that contain ActionBarSherlock.

Thanks!

Hugo

@hoang8f
Copy link
Collaborator

hoang8f commented Jun 6, 2014

Hi @hugocroch
Thank you for your suggestion 👍
Actually, I didn't think about that kind of conflict when I created this library.
I will let you know when appcompat is removed .

@hugocroch
Copy link
Author

Your welcome for the suggestion and Thanks for the reply @hoang8f !

@hoang8f hoang8f closed this as completed in 5909c72 Jun 7, 2014
@hoang8f
Copy link
Collaborator

hoang8f commented Jun 7, 2014

Hi @hugocroch
appcomp has been removed :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants