Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing redundant LayoutParam creation. #30

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tslamic
Copy link

@tslamic tslamic commented May 23, 2015

Hi guys,

I believe creating new layout params in the updateBackground() is redundant.

I was also tempted to change

params.setMargins(0, 0, -mMarginDp, 0);
params.setMargins(0, 0, 0, -mMarginDp);

to

params.rightMargin = -mMarginDp;
params.bottomMargin = -mMarginDp;

but I'm not sure if setting other margins to 0 was done on purpose. If not, maybe this shouldn't be reset to 0, since the user might have set the margins?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant