feat: create PostView via QiitaAPI following MVVM + Clean Architecture #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KaoruMuta
changed the title
KaoruMuta
commented
Jul 31, 2020
| @@ -1,4 +1,5 @@ | |||
| github "ReactiveX/RxSwift" == 5.0 | |||
| github "ReactiveX/RxSwift" == 5.1.1 | |||
There was a problem hiding this comment.
When a version of RxSwift is 5.0, some crash happened.
- Produced RxSwift.framework via Carthage, store in
Carthage/iOS/Build/Static/* - Not worked databinding between ui and tableView
Error is as follows.
failed to demangle superclass of DelegateProxy from mangled name 'So16_RXDelegateProxyC'
added 10 commits
July 31, 2020 22:39
|
【Improved Point】
|
KaoruMuta
added a commit
that referenced
this pull request
Jun 27, 2021
#15) * feat: create PostView * feat: succeeded in getting data from QiitaAPI * refactor: add translator but binding is not working * fix: modified Cartfile to change RxSwift Version * feat: succeed in loading data and showing data in tableview * feat: show LGTM number * refactor: modified layout and add final access * feat: add swiftgen.yml and SafariViewController an d itemSelected * feat: add deselectrow method * feat: change color in Main Screen * improvement: modified layout * feat: add assets and titleView in navigationbar * improvement: respond to darkmode * refactor: add datastore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
#3 #10 #13
What is changed in this PR?
AlamofireCheck if the PR fulfills these requirements
Squash and Mergeas a kind of merge