This repository has been archived by the owner on Nov 27, 2023. It is now read-only.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #764 +/- ##
============================================
+ Coverage 78.75% 78.88% +0.12%
Complexity 159 159
============================================
Files 54 54
Lines 2980 3064 +84
Branches 506 534 +28
============================================
+ Hits 2347 2417 +70
- Misses 421 424 +3
- Partials 212 223 +11 |
Wow, so easy to add health checks? 🥳 |
Delawen
approved these changes
Jul 11, 2023
lburgazzoli
force-pushed
the
quarkus
branch
2 times, most recently
from
July 11, 2023 15:13
7ae4f8c
to
b9ec093
Compare
@Delawen @igarashitm is there a way to tweak the sonar and codecov ? |
About codecov, I can't push this directly to your repo, but this should fix it: lburgazzoli#1 |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is aimed to leverage some quarkus native features such as:
For what concern container images, it is now possible to create container images from maven, as example by running the following commands:
We generates the following container images:
Note that, the build of native image does not require anymore to have GraalVM installed on the local machine as the build happens inside a container which and would automatically use the right GraalVM according to the Quarkus version.
Everything is configured by a dedicated profile so it should not change the current behavior, however, by leveraging those new profiles, we could simplify the CI/CD pipeline and make it very symmetric to the local dev experience.
WDYT ?