This repository has been archived by the owner on Nov 27, 2023. It is now read-only.
feat(branching): add support to edit branch step properties #1087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore(test): also test for falsey value before flattening array in test chore(viz): add function for building branch info separately chore(viz): refactor to include branchInfo in steps add utility to find path to deeply nested structures chore(branching): add store for lookup table for all nested steps chore(test): update test for utils chore(branching): add function to extract nested steps, add test chore(branching): update nested steps store after regenerating UUIDs chore(branching): check if step is nested prior to saving config fix(branching): allow typing into properties field of nested step chore(utils): add pathToString for fetching deeply nested values feat(branching): use path to update deeply nested portion of step chore(utils): add utility to modify deeply nested portion of step
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov Report
@@ Coverage Diff @@
## main #1087 +/- ##
==========================================
+ Coverage 43.19% 43.90% +0.70%
==========================================
Files 49 51 +2
Lines 1498 1574 +76
Branches 325 340 +15
==========================================
+ Hits 647 691 +44
- Misses 808 838 +30
- Partials 43 45 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
kahboom
force-pushed
the
branch-step-props
branch
from
a75bf58
to
c7f643c
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
kahboom
added a commit
to kahboom/kaoto-ui
that referenced
this pull request
Jan 17, 2023
…1087) * chore(viz): use findStepIdxWithUuid instead of native find, to find step to select * feat(viz): adds ability to view branch step properties chore(test): also test for falsey value before flattening array in test chore(viz): add function for building branch info separately chore(viz): refactor to include branchInfo in steps add utility to find path to deeply nested structures chore(branching): add store for lookup table for all nested steps chore(test): update test for utils chore(branching): add function to extract nested steps, add test chore(branching): update nested steps store after regenerating UUIDs chore(branching): check if step is nested prior to saving config fix(branching): allow typing into properties field of nested step chore(utils): add pathToString for fetching deeply nested values feat(branching): use path to update deeply nested portion of step chore(utils): add utility to modify deeply nested portion of step * feat(branching): handle deeply nested steps in saveConfig
kahboom
added a commit
to kahboom/kaoto-ui
that referenced
this pull request
Jan 17, 2023
…1087) * chore(viz): use findStepIdxWithUuid instead of native find, to find step to select * feat(viz): adds ability to view branch step properties chore(test): also test for falsey value before flattening array in test chore(viz): add function for building branch info separately chore(viz): refactor to include branchInfo in steps add utility to find path to deeply nested structures chore(branching): add store for lookup table for all nested steps chore(test): update test for utils chore(branching): add function to extract nested steps, add test chore(branching): update nested steps store after regenerating UUIDs chore(branching): check if step is nested prior to saving config fix(branching): allow typing into properties field of nested step chore(utils): add pathToString for fetching deeply nested values feat(branching): use path to update deeply nested portion of step chore(utils): add utility to modify deeply nested portion of step * feat(branching): handle deeply nested steps in saveConfig
mmelko
pushed a commit
to mmelko/kaoto-ui
that referenced
this pull request
Jan 23, 2023
…1087) * chore(viz): use findStepIdxWithUuid instead of native find, to find step to select * feat(viz): adds ability to view branch step properties chore(test): also test for falsey value before flattening array in test chore(viz): add function for building branch info separately chore(viz): refactor to include branchInfo in steps add utility to find path to deeply nested structures chore(branching): add store for lookup table for all nested steps chore(test): update test for utils chore(branching): add function to extract nested steps, add test chore(branching): update nested steps store after regenerating UUIDs chore(branching): check if step is nested prior to saving config fix(branching): allow typing into properties field of nested step chore(utils): add pathToString for fetching deeply nested values feat(branching): use path to update deeply nested portion of step chore(utils): add utility to modify deeply nested portion of step * feat(branching): handle deeply nested steps in saveConfig
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for editing branch step properties. It should have been two separate PRs, but making properties viewable without ability to edit would have been more effort than it was worth.
flattenSteps) to flatten steps to quickly find a deeply nested step, which is used when you select a branch step and is set as the main selected stepUUID, its origin parentUUID(the root step), and thepathto that step, for quick reference throughout the appextractNestedSteps) to extract all nested steps into an array, used in the storeinsertStepandreplaceStepmethods to regenerate the nested steps store on change, to check the nested step store to determine if the step is nested, and to handle it separately if it isresolves #784