Skip to content
This repository has been archived by the owner on Nov 27, 2023. It is now read-only.

Add gzip config to nginx server #1375

Merged
merged 2 commits into from Mar 3, 2023
Merged

Conversation

lordrip
Copy link
Member

@lordrip lordrip commented Mar 3, 2023

Description

At the moment, there is no gzip configuration enabled for the nginx server, meaning that all payloads are being sent to clients without compression.

This commit enabled gzip on the nginx side to reduce the amount of data transferred over the wire

Changes

filename size gzip
mini-catalog 1.77 MB 37.94 kB
catalog 7.18 MB 133.73 kB

Before

Screenshot from 2023-03-03 11-42-31

After

Screenshot from 2023-03-03 11-47-48

fixes #1363

At the moment, there is no gzip configuration enabled
for the nginx server, meaning that all payloads are being sent
to clients without compression.

This commit enabled gzip on the nginx side to reduce the amount
of data transferred over the wire

fixes #1363
@lordrip lordrip requested a review from a team March 3, 2023 10:55
@codecov
Copy link

codecov bot commented Mar 3, 2023

Codecov Report

Merging #1375 (4acdb16) into main (f0997ce) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1375   +/-   ##
=======================================
  Coverage   52.93%   52.93%           
=======================================
  Files          56       56           
  Lines        1910     1910           
  Branches      435      435           
=======================================
  Hits         1011     1011           
  Misses        851      851           
  Partials       48       48           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@mmelko mmelko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good but I don't think this is a correct formatting:
please use https://nginxbeautifier.github.io/ or something similar

@mmelko mmelko self-requested a review March 3, 2023 11:26
Copy link
Contributor

@mmelko mmelko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see the comment above

@sonarcloud
Copy link

sonarcloud bot commented Mar 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mmelko mmelko merged commit 2ae665e into KaotoIO:main Mar 3, 2023
@lordrip lordrip deleted the add-gzip-to-nginx branch May 6, 2023 17:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable gzip on nginx proxy
3 participants