This repository has been archived by the owner on Nov 27, 2023. It is now read-only.
fix(step-details): Sort step's parameters #1536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the moment, we're using the same order provided from the backend
to present the step's parameter list to the user. Sometimes this is
problematic because for some steps, the required fields are at the
end of the list.
This commit sort the step's parameter list using the following criteria:
1. Move mandatory parameters to the top
2. Sort them alphabetically
3. Sort alphabetically the rest of the parameters
fixes #1301
lordrip
force-pushed
the
fix/sort-step-parameters
branch
from
1eba93d
to
6aebeca
Compare
|
SonarCloud Quality Gate failed.
|
Codecov Report
@@ Coverage Diff @@
## main #1536 +/- ##
==========================================
+ Coverage 56.46% 56.96% +0.50%
==========================================
Files 64 68 +4
Lines 2019 2045 +26
Branches 464 468 +4
==========================================
+ Hits 1140 1165 +25
- Misses 833 834 +1
Partials 46 46
... and 5 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
kahboom
approved these changes
Mar 22, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, we're using the same order provided by the backend to present the step's parameter list to the user. Sometimes this is problematic because, for some steps, the required fields are at the end of the list.
This commit sorts the step's parameter list using the following criteria:
debezium-mongodb
fixes #1301