This repository has been archived by the owner on Nov 27, 2023. It is now read-only.
chore(test): add unit tests for all stores #1606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kahboom
force-pushed
the
test-services-store
branch
from
46a3f6d
to
8ff18f2
Compare
chore: Provide a zustand mock chore(test): remove duplicate zustand mock file chore(test): add tests for nestedStepsStore chore(test): add tests for nestedStepsStore chore(test): add tests for integrationSourceStore chore(test): add tests for integrationJsonStore
chore(test): add tests for integrationJsonStore
…eViews chore(test): add tests for visualizationStore chore(test): add tests for stepCatalogStore chore(test): add tests for deploymentStore chore(test): add tests for settingsStore chore: fix broken unit test
kahboom
force-pushed
the
test-services-store
branch
from
8ff18f2
to
3a12fe3
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
igarashitm
approved these changes
Mar 31, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds unit tests for all Zustand stores, since this was one of the areas with the lowest test coverage.
Changes
replaceParentStepinstead ofreplaceStep, orupdateViewsinstead ofsetViews)updateIntegrationmethod invisualizationStoreTasks remaining: Next PR will be focusing on other areas that are also lacking test coverage, such as
servicesandapi.Screenshots
Current code coverage for
store(43.13%):It should be 100% after this PR is merged.