Skip to content
This repository has been archived by the owner on Nov 27, 2023. It is now read-only.

Replace "null" string with "No default value" #1614

Merged
merged 2 commits into from
Apr 4, 2023

Conversation

unsortedhashsets
Copy link
Member

Hi,

here is a small change of null to a more friendly value No default value

Before:
image

After:
Screenshot from 2023-04-03 14-47-05

Relates:

@unsortedhashsets unsortedhashsets requested a review from a team April 3, 2023 12:52
@codecov
Copy link

codecov bot commented Apr 3, 2023

Codecov Report

Merging #1614 (0cc8877) into main (c5b9a68) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1614   +/-   ##
=======================================
  Coverage   61.05%   61.05%           
=======================================
  Files          70       70           
  Lines        2054     2054           
  Branches      470      470           
=======================================
  Hits         1254     1254           
  Misses        756      756           
  Partials       44       44           
Impacted Files Coverage Δ
src/components/FieldLabelIcon.tsx 90.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@kahboom kahboom linked an issue Apr 3, 2023 that may be closed by this pull request
@kahboom
Copy link
Collaborator

kahboom commented Apr 3, 2023

Thanks @unsortedhashsets. Would be good to get @apupier's review since he opened the original issue.

Copy link
Member

@apupier apupier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to provide the No default value in italic easily to try to have the clearest possible distinction?

@unsortedhashsets
Copy link
Member Author

No default value

Hi @apupier,

Now:

Without default:
Screenshot from 2023-04-04 09-44-55

With default:
Screenshot from 2023-04-04 09-45-01

@sonarcloud
Copy link

sonarcloud bot commented Apr 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
27.9% 27.9% Duplication

@Delawen Delawen merged commit df7a330 into KaotoIO:main Apr 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mention no default value instead of null in help popover
4 participants