Skip to content
This repository has been archived by the owner on Nov 27, 2023. It is now read-only.

Adds integration with Kogito functionalities to be able to run in a VSCode extension #750

Merged
merged 24 commits into from
Oct 11, 2022

Conversation

thiagoelg
Copy link
Contributor

@thiagoelg thiagoelg commented Sep 30, 2022

All commits here should probably be squashed.

TODO:

  • Merge with main;
  • Figure out how to pass process.env.KAOTO_API when building the lib;
    • Solved by defining process.env.KAOTO_API in webpack.config.js at vscode-kaoto.
  • Fix problems after new React Flow version

@thiagoelg thiagoelg marked this pull request as ready for review September 30, 2022 19:56
@kahboom
Copy link
Collaborator

kahboom commented Oct 4, 2022

@thiagoelg did you want for me to review this already or wait until the other tasks are checked off? and thanks btw! :)

@codecov-commenter
Copy link

codecov-commenter commented Oct 4, 2022

Codecov Report

Merging #750 (b613d55) into main (b0f9825) will decrease coverage by 0.22%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main     #750      +/-   ##
==========================================
- Coverage   42.70%   42.47%   -0.23%     
==========================================
  Files          45       45              
  Lines        1344     1363      +19     
  Branches      277      280       +3     
==========================================
+ Hits          574      579       +5     
- Misses        727      741      +14     
  Partials       43       43              
Impacted Files Coverage Δ
src/components/Visualization.tsx 55.69% <ø> (-0.56%) ⬇️
src/components/import.ts 4.54% <ø> (ø)
src/store/settingsStore.tsx 71.42% <ø> (ø)
src/utils/index.ts 42.85% <16.66%> (-10.48%) ⬇️
src/store/integrationJsonStore.tsx 26.41% <55.55%> (+2.50%) ⬆️
src/components/Catalog.tsx 56.25% <100.00%> (ø)
src/components/MiniCatalog.tsx 58.33% <100.00%> (+1.81%) ⬆️
src/components/PlusButtonEdge.tsx 47.82% <100.00%> (-2.18%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@thiagoelg
Copy link
Contributor Author

@kahboom feel free to review :)

But right now there seems to be a problem with the new version of React Flow that you might be able to help me with.
Running Kaoto UI by itself works fine, but running it inside VSCode makes it so the canvas is not interactable, and clicking and dragging are not responsive.

Code_cX8oWALfQA
(The gif doesn't show clicks, but I was trying to click and drag)

This seems like a CSS problem, but I wasn't able to find the source of the problem so far.

@thiagoelg
Copy link
Contributor Author

Ok, I think I fixed it... seems like importing CSS from inside a local CSS file works better for the VSCode extension (something related to how webpack resolve these files)

@kahboom
Copy link
Collaborator

kahboom commented Oct 5, 2022

Glad to hear that @thiagoelg , if you run into any other problems let me know.

@thiagoelg
Copy link
Contributor Author

thiagoelg commented Oct 6, 2022

Hey @kahboom, I think this is finally finished! 🎉
Let me know if there's something that could be different or if I missed anything, thanks!

Oh, and about publishing, I don't think I can do that by myself, It'll have to be done after merging the PR, let me know if you need any help.

package.json Show resolved Hide resolved
@kahboom
Copy link
Collaborator

kahboom commented Oct 7, 2022

@thiagoelg this looks great, I reviewed it but I'm wondering, what is the easiest way to test it?

@thiagoelg
Copy link
Contributor Author

@thiagoelg this looks great, I reviewed it but I'm wondering, what is the easiest way to test it?

Probably via the VSCode extension, there are some instructions in this PR: KaotoIO/vscode-kaoto#30

Testing VSCode extensions is a bit tricky, let me know if something doesn't work or if you need any help. I could probably send a built .vsix file too if necessary

Copy link
Collaborator

@kahboom kahboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thiagoelg - Tiny change request, after that it'd be good to squash the commits. Then we're good to go!

package.json Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Oct 10, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Collaborator

@kahboom kahboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @thiagoelg 🥳 🎉

@kahboom kahboom merged commit 11605ee into KaotoIO:main Oct 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants