-
Notifications
You must be signed in to change notification settings - Fork 44
Adds integration with Kogito functionalities to be able to run in a VSCode extension #750
Conversation
@thiagoelg did you want for me to review this already or wait until the other tasks are checked off? and thanks btw! :) |
Codecov Report
@@ Coverage Diff @@
## main #750 +/- ##
==========================================
- Coverage 42.70% 42.47% -0.23%
==========================================
Files 45 45
Lines 1344 1363 +19
Branches 277 280 +3
==========================================
+ Hits 574 579 +5
- Misses 727 741 +14
Partials 43 43
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@kahboom feel free to review :) But right now there seems to be a problem with the new version of React Flow that you might be able to help me with.
This seems like a CSS problem, but I wasn't able to find the source of the problem so far. |
Ok, I think I fixed it... seems like importing CSS from inside a local CSS file works better for the VSCode extension (something related to how webpack resolve these files) |
Glad to hear that @thiagoelg , if you run into any other problems let me know. |
Hey @kahboom, I think this is finally finished! 🎉 Oh, and about publishing, I don't think I can do that by myself, It'll have to be done after merging the PR, let me know if you need any help. |
@thiagoelg this looks great, I reviewed it but I'm wondering, what is the easiest way to test it? |
Probably via the VSCode extension, there are some instructions in this PR: KaotoIO/vscode-kaoto#30 Testing VSCode extensions is a bit tricky, let me know if something doesn't work or if you need any help. I could probably send a built .vsix file too if necessary |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thiagoelg - Tiny change request, after that it'd be good to squash the commits. Then we're good to go!
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @thiagoelg 🥳 🎉
All commits here should probably be squashed.
TODO:
main
;process.env.KAOTO_API
when building the lib;process.env.KAOTO_API
in webpack.config.js atvscode-kaoto
.