Skip to content
This repository has been archived by the owner on Nov 27, 2023. It is now read-only.

chore: revert to previous scoped package name #916

Merged
merged 1 commit into from
Nov 8, 2022
Merged

Conversation

kahboom
Copy link
Collaborator

@kahboom kahboom commented Nov 8, 2022

@apupier will this be a problem for the vscode-plugin? this is so that we can publish to the kaoto org with the nice scoped name like we did previously: @kaoto/kaoto-ui

@kahboom kahboom requested a review from a team November 8, 2022 12:20
@sonarcloud
Copy link

sonarcloud bot commented Nov 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@apupier
Copy link
Member

apupier commented Nov 8, 2022

will this be a problem for the vscode-plugin?

I do not know the implications. @thiagoelg changed this package name 31f66fa
So @thiagoelg , what are the implications?
is it only a matter of using a different naming in VS Code kaoto to reference the dependency or it has more than that.
(so change in package.json, kaotoEditorEnvelopApp.ts, tsconfig.json and webpack.config.js and contributing.md )

@kahboom
Copy link
Collaborator Author

kahboom commented Nov 8, 2022

I believe @thiagoelg only changed it to revert from @thiagoelg/kaoto-ui back to kaoto-ui. Probably we would just need to update the dependency name in the vscode repo to be @kaoto/kaoto-ui, unless there is something else I'm missing.

@apupier
Copy link
Member

apupier commented Nov 8, 2022

created KaotoIO/vscode-kaoto#66 to align it in VS Code Kaoto project

@kahboom
Copy link
Collaborator Author

kahboom commented Nov 8, 2022

thanks @apupier !

@kahboom kahboom merged commit 5691bdf into main Nov 8, 2022
@kahboom kahboom deleted the package-name branch November 8, 2022 13:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants