Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression field loses the expression #722

Closed
lhein opened this issue Jan 24, 2024 · 0 comments · Fixed by #726
Closed

expression field loses the expression #722

lhein opened this issue Jan 24, 2024 · 0 comments · Fixed by #726
Assignees
Labels
bug Something isn't working canvas/config-form Configuration form related issues
Milestone

Comments

@lhein
Copy link
Contributor

lhein commented Jan 24, 2024

The Expression field loses its data.

Image

@lhein lhein added bug Something isn't working canvas/config-form Configuration form related issues labels Jan 24, 2024
@lhein lhein added this to the 2.0.0 TP1 milestone Jan 24, 2024
@igarashitm igarashitm self-assigned this Jan 24, 2024
igarashitm added a commit to igarashitm/kaoto-next that referenced this issue Jan 24, 2024
lordrip added a commit to lordrip/kaoto that referenced this issue Jan 25, 2024
lordrip added a commit to lordrip/kaoto that referenced this issue Jan 25, 2024
Currently, using the following order works:
        1. Add a `setHeaders` step
        2. Configure the `name` property
        3. Configure the `expression` field

Now, it's not the case when going in the opposite direction.

This happens because when starting with an empty `setHeaders` step, both
the `Form` and the `ExpressionField` don't have any information and
they start with an empty object.

After configuring the `ExpressionField`, the `Form` still doesn't know
about the recently configured expression, and since the `Form` operates in an entire-object-update fashion, it removes the already configured `expression`.

The opposite doesn't happen because the `ExpressionField` checks the latest definition before updating it.

The workaround is to perform single-property operations in the `Form`, this way, the `Form` works in an additive way, preserving what was already set.

A more robust solution would be to perform the processor parsing before opening the `Form`, so we can incorporate the `ExpressionField` component into the `autoform` context.

fix: KaotoIO#722
lordrip added a commit that referenced this issue Jan 25, 2024
Currently, using the following order works:
        1. Add a `setHeaders` step
        2. Configure the `name` property
        3. Configure the `expression` field

Now, it's not the case when going in the opposite direction.

This happens because when starting with an empty `setHeaders` step, both
the `Form` and the `ExpressionField` don't have any information and
they start with an empty object.

After configuring the `ExpressionField`, the `Form` still doesn't know
about the recently configured expression, and since the `Form` operates in an entire-object-update fashion, it removes the already configured `expression`.

The opposite doesn't happen because the `ExpressionField` checks the latest definition before updating it.

The workaround is to perform single-property operations in the `Form`, this way, the `Form` works in an additive way, preserving what was already set.

A more robust solution would be to perform the processor parsing before opening the `Form`, so we can incorporate the `ExpressionField` component into the `autoform` context.

fix: #722
igarashitm added a commit to igarashitm/kaoto-next that referenced this issue Jan 25, 2024
lordrip pushed a commit that referenced this issue Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working canvas/config-form Configuration form related issues
Projects
Archived in project
2 participants