feat(Catalog): Add RouteConfiguration related entities #1012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lordrip
changed the title
lordrip
force-pushed
the
feat/add-route-configuration-tiles
branch
from
ef2d88a
to
df8f17b
Compare
lhein
reviewed
Apr 16, 2024
| @@ -366,7 +366,7 @@ describe('Camel Route', () => { | |||
| const logWhenNode = whenNode?.getChildren()?.[0]; | |||
| expect(logWhenNode).toBeDefined(); | |||
| expect(logWhenNode!.data.path).toEqual('from.steps.1.choice.when.0.steps.0.log'); | |||
| expect(logWhenNode!.getNodeLabel()).toEqual('log'); | |||
| expect(logWhenNode!.getNodeLabel()).toEqual('log-1'); | |||
There was a problem hiding this comment.
I am baffled by this one....the test label says "should use uri as label" but here it seems we check for an id?
There was a problem hiding this comment.
mmm, suspicious, I'll check again
There was a problem hiding this comment.
Ok, the test is to check that all nodes are creted properly. This particular expectation is checking the node's label and since this change, for a processor, the label algorithm goes like this:
- Description
- Id
- Component name
case 'to':
case 'toD':
return uriString ?? id ?? camelElementLookup.processorName;There was a problem hiding this comment.
ok, I see. the test description was a bit misleading
There was a problem hiding this comment.
I reworked this section to only show IDs as a fallback for entities, like intercept*, errorHandler and onException
As a prerequisite of KaotoIO#492, we need to add the related entities to the catalog. This commit adds the following entities: * intercept * interceptFrom * interceptSendToEndpoint * onException * onCompletion In addition to that, we also show the entity ID if provided in case there's no description available. relates: KaotoIO#492
lordrip
force-pushed
the
feat/add-route-configuration-tiles
branch
from
df8f17b
to
d42e30d
Compare
lhein
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
As a prerequisite of #492, we need to add the related entities to the catalog.
This commit adds the following entities:
In addition to that, we also show the entity ID if provided in case there's no description available.
Note
These entities will be available in an upcoming PR when the
RouteConfigurationvisual entity class is introduced.relates: #492