feat(Canvas): Consolidate groups interactions #1016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lordrip
force-pushed
the
feat/add-items-group-node
branch
from
2752996
to
477304c
Compare
lhein
approved these changes
Apr 16, 2024
lordrip
force-pushed
the
feat/add-items-group-node
branch
from
477304c
to
7d02a2c
Compare
Currently, expanded and collapsed groups don't have the interactions available, for instance: * Expanded groups: Only allowed to delete the entire flow * Collapsed groups: Only allowed to Insert step This commit consolidates both functionalities where it makes sense, so expanded groups allow the deletion of the flow, and collapsed ones allow to insert step (which expands the group) and the deletion of the entire flow. relates: KaotoIO#492
lordrip
force-pushed
the
feat/add-items-group-node
branch
from
7d02a2c
to
1abee5e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Currently, expanded and collapsed groups don't have the interactions available, for instance:
This commit consolidates both functionalities where it makes sense, so expanded groups allow the deletion of the flow, and collapsed ones allow to insert step (which expands the group) and the deletion of the entire flow.
How to test
Use the following route
You should see in both expanded and collapsed groups the
Delete flowoptionrelates: #492