Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Canvas): Add missing unit test for Canvas.tsx #1029

Merged
merged 2 commits into from
Apr 23, 2024

Conversation

lordrip
Copy link
Member

@lordrip lordrip commented Apr 23, 2024

Context

Add missing test for delete flow functionality through the canvas.

This test was initially created by @shivamG640, it just needed a little touch in terms of the provider.

The issue was that since the TestProvidersWrapper provider was used, there was no real access to the underlying camel resource. The fix is to manually provide the camel resource so we can access the real object.

relates: #974
fix: #1007

@lordrip lordrip requested a review from shivamG640 April 23, 2024 11:47
Add missing test for delete flow functionality through the canvas.

relates: KaotoIO#974
@lordrip lordrip force-pushed the chore/add-unit-test-for-canvas branch from 0043640 to 8959e4b Compare April 23, 2024 12:02
@lordrip lordrip merged commit 7ab49c5 into KaotoIO:main Apr 23, 2024
6 checks passed
@lordrip lordrip deleted the chore/add-unit-test-for-canvas branch April 23, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add unit test for deleting a Camel Route
2 participants