Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Use a Typeahead component for the DataFormat and LoadBalancer Field #1054

Merged
merged 1 commit into from
May 2, 2024
Merged

fix: Use a Typeahead component for the DataFormat and LoadBalancer Field #1054

merged 1 commit into from
May 2, 2024

Conversation

igarashitm
Copy link
Contributor

Fixes: #903

@igarashitm igarashitm requested a review from lordrip May 2, 2024 01:44
lordrip
lordrip approved these changes May 2, 2024
View reviewed changes
Copy link
Member

@lordrip lordrip left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, this is very helpful, I'll create a ticket to extract the common part of DataFormatEditor, ExpressionEditor, and LoadBalancerEditor so we can reduce the footprint of them. (#1054)

@lordrip lordrip mentioned this pull request May 2, 2024
Closed
@lordrip lordrip merged commit e054d2d into KaotoIO:main May 2, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lordrip lordrip lordrip approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use a Typeahead component for the DataFormat and LoadBalancer Field
2 participants
@igarashitm @lordrip