feat(Canvas): Disable steps #1065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apupier
reviewed
May 7, 2024
lordrip
force-pushed
the
feat/disable-steps
branch
from
44ca58c
to
99b18ac
Compare
Some EIPs provide a `disabled` property to ignore them during the runtime. This commit adds a quick access to that property, so users can easily enable/disable nodes in the canvas. In addition to that, the step is grayed out when disabled. fix: KaotoIO#758 fix: KaotoIO#699
lordrip
force-pushed
the
feat/disable-steps
branch
from
99b18ac
to
508b668
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
This PR is still a draft because the disabling effect should be more explicit
Context
Some EIPs provide a
disabledproperty to ignore them during the runtime.Changes
This commit adds quick access to that property, so users can easily enable/disable nodes in the canvas. In addition to that, the step is grayed out when disabled.
Screenshots
fix: #758
fix: #699