Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use Simple as default selection for expression #1068

Merged
merged 3 commits into from
May 7, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -46,5 +46,59 @@ describe('CamelComponentDefaultService', () => {
expect(doCatchDefault.id).toBeDefined();
expect(doCatchDefault.exception).toHaveLength(1);
});

it('should return the default value for a setHeader processor', () => {
const setHeaderDefault = CamelComponentDefaultService.getDefaultNodeDefinitionValue({
type: 'processor',
name: 'setHeader',
} as DefinedComponent);
expect(setHeaderDefault.setHeader).toBeDefined();
expect((setHeaderDefault.setHeader!.id as string).startsWith('setHeader-')).toBeTruthy();
expect(setHeaderDefault.setHeader!.name).toBeUndefined();
expect((setHeaderDefault.setHeader!.expression as any).simple.expression).toEqual('');
});

it('should return the default value for a setProperty processor', () => {
const setPropertyDefault = CamelComponentDefaultService.getDefaultNodeDefinitionValue({
type: 'processor',
name: 'setProperty',
} as DefinedComponent);
expect(setPropertyDefault.setProperty).toBeDefined();
expect((setPropertyDefault.setProperty!.id as string).startsWith('setProperty-')).toBeTruthy();
expect(setPropertyDefault.setProperty!.name).toBeUndefined();
expect((setPropertyDefault.setProperty!.expression as any).simple.expression).toEqual('');
});

it('should return the default value for a setVariable processor', () => {
const setVariableDefault = CamelComponentDefaultService.getDefaultNodeDefinitionValue({
type: 'processor',
name: 'setVariable',
} as DefinedComponent);
expect(setVariableDefault.setVariable).toBeDefined();
expect((setVariableDefault.setVariable!.id as string).startsWith('setVariable-')).toBeTruthy();
expect(setVariableDefault.setVariable!.name).toBeUndefined();
expect((setVariableDefault.setVariable!.expression as any).simple.expression).toEqual('');
});

it('should return the default value for a setBody processor', () => {
const setBodyDefault = CamelComponentDefaultService.getDefaultNodeDefinitionValue({
type: 'processor',
name: 'setBody',
} as DefinedComponent);
expect(setBodyDefault.setBody).toBeDefined();
expect((setBodyDefault.setBody!.id as string).startsWith('setBody-')).toBeTruthy();
expect((setBodyDefault.setBody!.expression as any).simple.expression).toEqual('');
});

it('should return the default value for a filter processor', () => {
const filterDefault = CamelComponentDefaultService.getDefaultNodeDefinitionValue({
type: 'processor',
name: 'filter',
} as DefinedComponent);
expect(filterDefault.filter).toBeDefined();
expect((filterDefault.filter!.id as string).startsWith('filter-')).toBeTruthy();
expect((filterDefault.filter!.expression as any).simple.expression).toEqual('');
expect(filterDefault.filter!.steps).toEqual([]);
});
});
});
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,51 @@ export class CamelComponentDefaultService {
steps: []
`);

case 'setHeader':
return parse(`
setHeader:
id: ${getCamelRandomId('setHeader')}
expression:
simple:
expression: ""
`);

case 'setProperty':
return parse(`
setProperty:
id: ${getCamelRandomId('setProperty')}
expression:
simple:
expression: ""
`);

case 'setVariable':
return parse(`
setVariable:
id: ${getCamelRandomId('setVariable')}
expression:
simple:
expression: ""
`);

case 'setBody':
return parse(`
setBody:
id: ${getCamelRandomId('setBody')}
expression:
simple:
expression: ""
`);

case 'filter':
return parse(`
filter:
id: ${getCamelRandomId('filter')}
expression:
simple:
expression: ""
steps: []
`);
igarashitm marked this conversation as resolved.
Show resolved Hide resolved
default:
return {
[processorName]: {
Expand Down
Loading