fix(canvas): Refresh canvas after error #715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, if there's an error during a flow parsing, an error message is shown to the user to explain what happens and suggest checking the source code. In the VSCode extension, the canvas doesn't refresh after an error, causing the editor to be stuck until the user closes the extension and reopens it again or switches to another tab. This commit addresses this issue by assigning a `key` property to the error boundary component, so it gets refreshed after an entity update that happens only after editing the source code. fix: KaotoIO#714
lordrip
changed the title
|
Why are they 26 changes in the |
I don't know, seems a bit strange as checking the "changes" don't show anything different at glance |
apupier
approved these changes
Jan 24, 2024
There was a problem hiding this comment.
if the changes mentione din UI Review Chromatic job are not too much suspicious, i'm fine with it.
I tested locally and it is working as expected.
I reported a task to have a non-regression test KaotoIO/vscode-kaoto#457
igarashitm
approved these changes
Jan 24, 2024
|
It looks like all the stories are considered new one in chromatic. It suggests for some reason chromatic lost the track with current main branch and take the diff. Hoping that's a temporary issue at their side. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Currently, if there's an error during a flow parsing, an error message is shown to the user to explain what happens and suggest checking the source code. In the VSCode extension, the canvas doesn't refresh after an error, causing the editor to be stuck until the user closes the extension and reopens it again or switches to another tab.
This commit addresses this issue by assigning a
keyproperty to the error boundary component, so it gets refreshed after an entity update that happens only after editing the source code.fix: #714