Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(592) - Click on 2 more for tag of a component #749

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

tplevko
Copy link
Contributor

@tplevko tplevko commented Jan 26, 2024

fixes #592

Copy link
Contributor

@igarashitm igarashitm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, good catch 👍

Copy link
Member

@lordrip lordrip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was looking at the PR and trying to understand why was this happening.

For my future self:

This happens because the label node spans the entire tile
image

And since the label node is a child of the header div, it was capturing all clicks
image

Extremely good catch @tplevko 👏

@lordrip lordrip merged commit e1b53e8 into KaotoIO:main Jan 29, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Click on 2 more for tag of a component in the catalog is selecting it instead of showing the 2 tags
3 participants