fix(702): static catalog filter at the top of page #778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lordrip
approved these changes
Feb 2, 2024
Comment on lines
32
to
36
| useEffect(() => { | ||
| document.getElementById('catalog-list')!.scrollTop = 0; | ||
| }, [props.tiles]); | ||
|
|
There was a problem hiding this comment.
@tplevko This is a great addition 🎉 , I would just suggest if possible, using Ref to get the element instead.
Maybe something like this could work:
const catalogBodyRef = useRef<HTMLDivElement>(null);
useEffect(() => {
catalogBodyRef.current?.scrollTop = 0;
}, [props.tiles]);
return (
<div id="catalog-list" className="catalog-list" ref={catalogBodyRef}>
...This way we're resilient against changes and more important, we delegate the object fetching to react.
There was a problem hiding this comment.
Great, thanks for the hint! Works with no issue.
I also moved the div, so we would have static displayed element counter at the top.
vokoscreenNG-2024-02-02_12-17-32.mp4
tplevko
force-pushed
the
issue_702
branch
4 times, most recently
from
10176fe
to
f33f003
Compare
lordrip
reviewed
Feb 2, 2024
| @@ -28,25 +30,31 @@ export const BaseCatalog: FunctionComponent<BaseCatalogProps> = (props) => { | |||
| [onTileClick, props.tiles], | |||
| ); | |||
|
|
|||
| useEffect(() => { | |||
| catalogBodyRef.current!.scrollTop = 0; | |||
There was a problem hiding this comment.
I think in this case, we can leave it because the div is static, we just need to be aware that this might not be the case always 👀 and we can go 💥
lordrip
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #702
vokoscreenNG-2024-02-02_11-56-08.mp4