chore(deps): Update @patternfly/* dependencies #791
Conversation
lordrip
force-pushed
the
chore/update-patternfly
branch
8 times, most recently
from
6caef10
to
f7b32e2
Compare
Updates: * `"@patternfly/patternfly": "5.2.0",` * `"@patternfly/react-code-editor": "5.1.0",` * `"@patternfly/react-core": "5.2.0",` * `"@patternfly/react-icons": "5.2.0",` * `"@patternfly/react-table": "5.2.0",` * `"@patternfly/react-topology": "5.2.0",` Notes: Notice that `@patternfly/react-code-editor` stayed at `5.1.0` since there's an ongoing issue breaking the `YAML` autocompletion support. The `@patternfly/react-topology` is being updated to `5.2.0` since is required to draw squared containers in the canvas. Unfortunately, there's an issue with a missing `pf-v5-u-screen-reader` class definition which forces the Canvas' buttons to show their label. In addition to that, `@patternfly/react-topology` changed the structure of the nodes and the e2e needed to be updated. Now, once a node is selected, the label gets promoted to a different layer, meaning that there's no easy way to target the three dots menu to open the contextual menu. In this case, this functionality was switched to a right click to display the same contextual menu. Relates to: KaotoIO#767
lordrip
force-pushed
the
chore/update-patternfly
branch
from
f7b32e2
to
d6780eb
Compare
| .eq(nodeIndex) | ||
| .find('g.pf-topology__node__action-icon > rect') | ||
| .click({ force: true }); | ||
| cy.get(`[data-nodelabel="${nodeName}"]`).parent().eq(nodeIndex).rightclick({ force: true }); |
There was a problem hiding this comment.
@tplevko, I need to change this functionality from getting the parent of the node to search for the three dots menu to right-click on the node because of a structural change in @patternfly/react-topology that moves the selected node label to another layer, so we can't continue going to the parent and search for the menu there.
| "@patternfly/react-table": "^5.0.0", | ||
| "@patternfly/react-topology": "^5.0.0", | ||
| "@patternfly/patternfly": "5.2.0", | ||
| "@patternfly/react-code-editor": "5.1.0", |
There was a problem hiding this comment.
At the moment we can't upgrade @patternfly/react-code-editor due to an issue affecting how we load schemas.
| "build:esm": "tsc --project tsconfig.esm.json && copyfiles -u 1 './src/**/*.scss' './src/assets/**' ./lib/esm", | ||
| "build:cjs": "tsc --project tsconfig.cjs.json && copyfiles -u 1 './src/**/*.scss' './src/assets/**' ./lib/cjs", |
There was a problem hiding this comment.
This is needed for executing commands in PowerShell, without the quotes, the ** gets expanded creating an error since the resulting line is too long
| toggleId="expandable-section-toggle" | ||
| contentId="expandable-section-content" |
There was a problem hiding this comment.
This is necessary because without both properties set, the id gets generated by a timestamp, breaking the snapshot tests on every run.
Context
Updates:
"@patternfly/patternfly": "5.2.0","@patternfly/react-code-editor": "5.1.0","@patternfly/react-core": "5.2.0","@patternfly/react-icons": "5.2.0","@patternfly/react-table": "5.2.0","@patternfly/react-topology": "5.2.0",Notes
Notice that
@patternfly/react-code-editorstayed at5.1.0since there's an ongoing issue breaking theYAMLautocompletion support.The
@patternfly/react-topologyis being updated to5.2.0since is required to draw squared containers in the canvas. Unfortunately, there's an issue with a missingpf-v5-u-screen-readerclass definition which forces the Canvas' buttons to show their label.Relates to: #767
Screenshots