fix(ajv): Avoid ajv throw exception for unresolved fields #798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, if a schema field cannot be resolved by using the `$ref` keyword, `ajv` throws an exception, making the `CanvasForm` unusable. In addition to that, the `form` field has been removed from the `CanvasForm` as is meant to be rendered by the `Canvas` itself. relates to: KaotoIO#767
lordrip
force-pushed
the
fix/avoid-ajv-throw-exception
branch
from
4df5440
to
c1f66cd
Compare
lhein
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if a schema field cannot be resolved by using the
$refkeyword,ajvthrows an exception, making theCanvasFormunusable.In addition to that, the
formfield has been removed from theCanvasFormas is meant to be rendered by theCanvasitself.relates to: #767