feat(canvas-form): Use CustomAutoForm #828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igarashitm
approved these changes
Feb 12, 2024
lordrip
force-pushed
the
feat/use-custom-autoform
branch
2 times, most recently
from
bc8f67f
to
a16eccb
Compare
Currently, there are 2 different `AutoForm` instances, one from `CanvasForm` and another one from the `MetadataEditor`. This leads to code duplication and different form behavior depending on which screen is displayed. This commit updates the `CanvasForm` and `MetadataEditor` components to use the `CustomAutoForm`.
lordrip
force-pushed
the
feat/use-custom-autoform
branch
from
a16eccb
to
0469053
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Currently, there are 2 different
AutoForminstances, one fromCanvasFormand another one from theMetadataEditor.This leads to code duplication and different form behavior depending on which screen is displayed.
Changes
This commit updates the
CanvasFormandMetadataEditorcomponents to use theCustomAutoForm.