feat(canvas): Loads the Kamelet Form with the Kamelet Schema #864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lordrip
reviewed
Feb 22, 2024
packages/ui/src/models/visualization/flows/kamelet-visual-entity.ts
Outdated
Show resolved
Hide resolved
lordrip
reviewed
Feb 22, 2024
lordrip
reviewed
Feb 22, 2024
5 tasks
…and added unit tests
shivamG640
force-pushed
the
issue782-3
branch
from
c643b32
to
6392de0
Compare
After updating the way how the Kamelet's model is updated, the `labels` and `annotations` objects are mutated, which is not ideal since makes the form complicated to use as the object fields are populated with the standalone fields as well. In addition to that, the Kamelet's custom schema is using Capitalized version of the `type` entry, for instance, `Action`, `Source` and `Sink` The fix is to recreate the object reference on each update and to fix the schema enum by using the right values. fix: KaotoIO#782
|
Looks good to me, but I'm noticing that we're missing a handler for the |
lordrip
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #782 partially.
This change loads the Kamelet Form with the Kamelet Schema