fix(CanvasForm): Avoid adding {} to the Source code
#879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the uniforms library, initializes object fields with empty objects when there's a required property inside them. This is prevented by checking the value of the incoming change in the CanvasForm component, and while this works, it collides with the Kamelet's custom form, since the user might want to remove all annotations, leaving the form with an intended empty object. The fix for this issue is to remove said check and place it in the `setValue` function instead. The mechanism now is to check whether the value to assign is an empty object, in which case it's replaced with an `undefined` value instead. This prevents for this value to be serialized into the Source code. fix: KaotoIO#878
tplevko
approved these changes
Feb 28, 2024
|
Thanks for the review @tplevko 💪 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the uniforms library, initializes object fields with empty objects when there's a required property inside them.
This is prevented by checking the value of the incoming change in the CanvasForm component, and while this works, it collides with the Kamelet's custom form, since the user might want to remove all annotations, leaving the form with an intended empty object.
The fix for this issue is to remove said check and place it in the
setValuefunction instead.The mechanism now is to check whether the value to assign is an empty object, in which case it's replaced with an
undefinedvalue instead.This prevents for this value to be serialized into the Source code.
fix: #878